diff options
author | JSDurand <mmemmew@gmail.com> | 2023-01-03 23:44:02 +0800 |
---|---|---|
committer | JSDurand <mmemmew@gmail.com> | 2023-01-03 23:44:02 +0800 |
commit | bdbd4b4dc21af09711c97d3f903877443199af06 (patch) | |
tree | c6a9602f72ee1f6fd7fd3f64b8679a4de50a0159 /receme | |
parent | 8463dd24f815fe2b8f25fe9763e0a43023bfbb20 (diff) |
structural change: separate crates out
I put functionalities that are not strictly core to separate crates,
so that the whole package becomes more modular, and makes it easier to
try other parsing algorithms in the future.
Also I have to figure the forests out before finishing the core
chain-rule algorithm, as the part about forests affects the labels of
the grammars directly. From my experiences in writing the previous
version, it is asking for trouble to change the labels type
dramatically at a later point: too many places need to be changed.
Thus I decide to figure the rough part of forests out.
Actually I only have to figure out how to attach forests fragments to
edges of the underlying atomic languages, and the more complex parts
of putting forests together can be left to the recorders, which is my
vision of assembling semi-ring values during the chain-rule machine.
It should be relatively easy to produce forests fragments from
grammars since we are just trying to extract some information from the
grammar, not to manipulate those information in some complicated way.
We have to do some manipulations in the process, though, in order to
make sure that the nulling and epsilon-removal processes do not
invalidate these fragments.
Diffstat (limited to 'receme')
-rw-r--r-- | receme/src/lib.rs | 2 | ||||
-rw-r--r-- | receme/src/tree.rs | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/receme/src/lib.rs b/receme/src/lib.rs index be1f028..d9e6249 100644 --- a/receme/src/lib.rs +++ b/receme/src/lib.rs @@ -48,7 +48,7 @@ pub mod ralgebra; // The following modules are for default implementations. pub mod tree; -// TODO: benchmarks +// REVIEW: Do we really need this crate? #[cfg(test)] mod test_expr_tree { diff --git a/receme/src/tree.rs b/receme/src/tree.rs index eb64f31..521f913 100644 --- a/receme/src/tree.rs +++ b/receme/src/tree.rs @@ -365,4 +365,4 @@ where } } -// TODO: Para, Apo, Histo, and Futu await us. +// REVIEW: Para, Apo, Histo, and Futu await us. |