| Age | Commit message (Collapse) | Author |
|---|
|
This crate is responsible for the users to conveniently define their
own tokenizers. Right now the user has to tokenize the input string
manually, which is not quite what is expected from a parser, from the
view point of users.
|
|
Not bug deals but adjustments of details.
|
|
* chain/src/item/default/splone.rs: A function for finding the node to
plant used to ignore the condition that the children should match.
Now this is fixed.
|
|
* chain/src/item/mod.rs: Some function and enum are needed across
crates.
|
|
* chain/src/atom/default.rs: Previously the nullibility of virtual
nodes is determined by the nullibility of all its out-going edges.
This is now determined only by the nullibility of out-going edges
that are not "left-linearly expanded". This is the correct
approach.
|
|
* chain/src/default.rs: This is useful for debugging the chain-rule
machine.
|
|
Some bugs are fixed:
1. If a non-terminal expansion can be reduced immediately, previously
an extra node would be created that had no parents. Now this strange
behaviour is corrected.
2. When performing reductions, a leaf non-terminal node would
previously be regarded as completed. Now we will first try to
complete that node, and then determine if the completion is
successful, and finally determine the completedness according to the
result.
Of course some more tests are still pending, before I can confirm that
no more bugs lurk around.
|
|
Adjust the codes slightly.
Also add a plan to implement the context-free memoization.
|
|
|
|
Use a better formatting style.
|
|
Fix the broken Makefiles.
|
|
I think I should make a new sub-crate dedicated to the tokenization
process instead.
|
|
Try to fix some minor issues.
|
|
* chain/src/item/default/printer.lldb:
* chain/src/item/default/printer.py: These are for experimenting with
debugger supports.
|
|
* chain/src/item/default/mod.rs:
* graph/src/labelled/binary.rs:
* graph/src/labelled/double.rs:
* graph/src/lib.rs: If we set the option "ordering" to be "out" in the
declaration of nodes at the beginning, then GraphViz will not change
the order of children out of nodes. This is much better looking in
my opinion.
* INSTALL: make insists in changing this file, so let it be.
|
|
I have fixed another bug and think that the version of a more stable
version is worth bumping the versions for.
|
|
Add an intentionally ambiguous grammar for testing purposes.
It seems to work fine.
|
|
* nfa/src/default/regex.rs: Previously when merging regular
expressoins, only the graphs are merged, but the `types` array
stayed unchanged. This caused errors of indices being out of
bounds.
|
|
Previously the errors emitted while reading abnf grammars reported
incorrect indices. Now this is fixed.
|
|
This makes it easier if I want to debug things.
|
|
|
|
|
|
This bumping of version is insignificant. I just find it notable that
I seem to finally obtain a version without trivial bugs. Hooray!
|
|
The chain-rule machine needs a place-holder node at the beginning.
But afterwards that node is pure annoyance and disturbs the
functioning of the machine. Consequently I removed that node whenever
the right time comes.
This seems to fix some other bugs. It is reasonable: the presence of
that bogus node is just noise to the machine and error-prone.
|
|
* chain/src/atom/default.rs (print_virtual): Previously printing
virtual nodes is done inside the function `print_nfa`; now this is
decoupled and thus more flexible.
|
|
* chain/src/item/genins.rs: The absolute path is too long and
unnecessary.
|
|
* grammar/src/label.rs (set_end_option): This function replaces the
old function `open_end`, as this new function is more general than
the old one, and there is no specific situation where we only need
to open the end of a node without the need to close the node in an
`if` statement.
|
|
* chain/src/item/default/splone.rs: Previouslt the function
`split_node` used to split the parents of splitted nodes by an ugly
logic. Now that is moved into a dedicated function, which properly
handles the splitting of parents, including the case when the new
node is open whereas the old node is closed, in which situation we
ought to put the new node under the opened node only, as a closed
node cannot contain an open node as a child by definition.
|
|
Huh.
|
|
* graph/src/lib.rs: Add a plan to reduce the number of
bounds-checking. Hopefully this makes the package more efficient.
|
|
* chain/src/atom/default.rs: Making this function public means I do
not have to worry about it being unused.
|
|
Previously a virtual fragment did not receive proper ending positions.
This is now fixed.
Additionally, after this fix, the function `set_pos` is only called
with the last parameter set to `t`. Maybe I shall remove this
parameter.
|
|
This bug caused a plain unambiguous grammar to become ambiguous.
Funnily enough, this bug revealed a lot of bugs in the code for
handling forests. I guess this is an unexpected surprise. :D
|
|
The function `set_pos` is kind of subtle and its behaviour needs a
unit test so that we can be sure that it does not accidentally set the
ending positions in a careless manner.
|
|
Previously when generating a fragment of the forest corresponding to
the expansion of a non-terminal by a terminal, we incorrectly set the
end of every node within it to be one plus the start, if the expansion
happens due to a reduction.
Now this mistake is fixed and the ending positions are correctly set.
|
|
* chain/src/atom/default.rs (print_nullables): This functions prints
the nullables nodes of an atomic language. This is useful whe
designing unit tests, as it enables us to know which rule positions
are considered accepting by the underlying testing atomic language.
|
|
* chain/src/item/default/splone.rs: Previously when we split nodes, we
always clone the parent if the labels differ. This turns out to be
incorrect if the new label is open whereas the old label is closed.
In that case, the old parent should not contain the new node as a
child, as a closed node should not contain an open node.
I am not yet entirely sure this fix is correct, so more test await
us.
|
|
This is not of much use right now, but can be helpful later.
|
|
In the process of splitting, cloning, and planting the forest, I
forgot to check whether some cloned node of the node inquestion
satisfy the condition. This used to cause forests that violate some
fundamental assumptions. Now this is supposed to be fixed, but more
tests await us.
|
|
* src/test.c: input is a malloc'ed pointer, which can be NULL due to
malloc not being able to allocate enough memory. So I have to guard
against this possibility.
Aside: Why are some intermediate files added again?
|
|
|
|
|
|
Those were added by accident.
|
|
|
|
Previously the functions `is_prefix` and `plant` did not take the
situation of packed nodes into considerations. That was because I
only dealt with non-packed nodes in the past: the fragment to test for
prefixes and for planting did not intersect the packed nodes in the
forest, and the grammar is so simple that the fragments do not contain
packed nodes.
Then a test revealed this situation, so I have to fix this lack of
considerations now. This commit attempts to fix this issue.
From the newly added unit-tests, it seems that this fix works. :)
|
|
I do not use a tool to automatically format the codes, so sometimes
the codes look ugly. This commit reformats the codes so that they
look better and shorter on each line.
|
|
Now the binding part is finished.
What remains is a bug encountered when planting a fragment to the
forest which intersects a packed node, which would lead to invalid
forests. This will also cause problem when planting a packed
fragment, but until now my testing grammars do not produce packed
fragments, so this problem is not encountered yet.
I am still figuring out efficient ways to solve this problem.
|
|
Adding a grammar and a document for testing purposes.
|
|
Add more directories under control of autotools.
|
|
There were two main issues in the previous version.
One is that there are lots of duplications of nodes when manipulating
the forest. This does not mean that labels repeat: by the use of the
data type this cannot happen. What happened is that there were cloned
nodes whose children are exactly equal. In this case there is no need
to clone that node in the first place. This is now fixed by checking
carefully before cloning, so that we do not clone unnecessary nodes.
The other issue, which is perhaps more important, is that there are
nodes which are not closed. This means that when there should be a
reuction of grammar rules, the forest does not mark the corresponding
node as already reduced. The incorrect forests thus caused is hard to
fix: I tried several different approaches to fix it afterwards, but
all to no avail. I also tried to record enough information to fix
these nodes during the manipulations. It turned out that recording
nodes is a dead end, as I cannot properly syncronize the information
in the forest and the information in the chain-rule machine. Any
inconsistencies will result in incorrect operations later on.
The approach I finally adapt is to perform every possible reduction at
each step. This might lead to some more nodes than what we need. But
those are technically expected to be there after all, and it is easy
to filter them out, so it is fine, from my point of view at the
moment.
Therefore, what remains is to filter those nodes out and connect it to
the holy Emacs. :D
|
