From 9a317e56f8a6126583f7d0c431bf878d9b1fe7b1 Mon Sep 17 00:00:00 2001
From: JSDurand <mmemmew@gmail.com>
Date: Sat, 8 Jul 2023 12:30:21 +0800
Subject: Finished the Emacs binding.

Now the binding part is finished.

What remains is a bug encountered when planting a fragment to the
forest which intersects a packed node, which would lead to invalid
forests.  This will also cause problem when planting a packed
fragment, but until now my testing grammars do not produce packed
fragments, so this problem is not encountered yet.

I am still figuring out efficient ways to solve this problem.
---
 chain/src/item/mod.rs | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

(limited to 'chain/src/item/mod.rs')

diff --git a/chain/src/item/mod.rs b/chain/src/item/mod.rs
index 54ca946..d2c3127 100644
--- a/chain/src/item/mod.rs
+++ b/chain/src/item/mod.rs
@@ -7,7 +7,7 @@
 
 use graph::{error::Error as GError, GraphLabel, LabelGraph, Parent, ParentsGraph};
 
-use core::borrow::Borrow;
+use std::borrow::Borrow;
 
 /// A parent or a virtual segment.
 ///
@@ -96,7 +96,7 @@ enum ForestLabelType {
     Cloned(usize),
 }
 
-impl core::fmt::Display for ForestLabelType {
+impl std::fmt::Display for ForestLabelType {
     fn fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::fmt::Result {
         match self {
             Self::Packed => write!(f, "packed"),
@@ -113,8 +113,8 @@ pub struct ForestLabel<T: GraphLabel> {
     status: ForestLabelType,
 }
 
-impl<T: GraphLabel> core::fmt::Display for ForestLabel<T> {
-    fn fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::fmt::Result {
+impl<T: GraphLabel> std::fmt::Display for ForestLabel<T> {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
         if !matches!(self.status, ForestLabelType::Plain) {
             write!(f, "{}, {}", self.label, self.status)
         } else {
@@ -132,8 +132,8 @@ pub enum ForestLabelError {
     ClonePack,
 }
 
-impl core::fmt::Display for ForestLabelError {
-    fn fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::fmt::Result {
+impl std::fmt::Display for ForestLabelError {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
         match self {
             Self::PackClone => write!(f, "cannot pack a cloned node"),
             Self::ClonePack => write!(f, "cannot clone a packed node"),
@@ -230,6 +230,9 @@ impl<T: GraphLabel> From<T> for ForestLabel<T> {
     }
 }
 
+// REVIEW: Should we move this trait (and only this trait) to a
+// separate crate, or is it enough to keep it here?
+
 /// The expected behaviours of an item derivation forest.
 ///
 /// Note that it requires only a subset of the functionalities of
-- 
cgit v1.2.3-18-g5258