From 68d3baa1346aec734f4f98a3044c0056694f1b76 Mon Sep 17 00:00:00 2001 From: JSDurand Date: Sun, 12 Feb 2023 15:49:28 +0800 Subject: fix clone not changing the root Previously cloning a node does not alter the root of the forest, while it should alter the root if the cloned node was the root. This would affect how we compare the equalities of forests. It indeed resulted in anomalies that were hard to solve. --- chain/src/item/default/splone.rs | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) (limited to 'chain/src/item/default/splone.rs') diff --git a/chain/src/item/default/splone.rs b/chain/src/item/default/splone.rs index 1168539..4f4835b 100644 --- a/chain/src/item/default/splone.rs +++ b/chain/src/item/default/splone.rs @@ -1,3 +1,4 @@ +#![allow(dead_code)] //! This module implements a function for "closing" and "splitting" a //! node in a forest, and hence the name. @@ -593,6 +594,12 @@ mod test_splone { let cloned = forest.clone_node(0, 0, false)?; + forest.plant( + cloned, + leaf!(GrammarLabel::new_closed(6, 0, 1), GrammarLabel), + true, + )?; + forest.plant( cloned, leaf!(GrammarLabel::new_closed(7, 1, 3), GrammarLabel), @@ -605,12 +612,6 @@ mod test_splone { false, )?; - forest.plant( - cloned, - leaf!(GrammarLabel::new_closed(6, 0, 1), GrammarLabel), - true, - )?; - let mut builder = PLGBuilderMut::from_graph_mut(&mut forest.graph); let dummy_label = ForestLabel::from(GrammarLabel::new(0, 0)); -- cgit v1.2.3-18-g5258